Trigger mkinitfs on device packages upgrade

boot-deploy, which is executed by mkinitfs, relies on many stuff from deviceinfo. So, if we modify deviceinfo we need to run mkinitfs

If we don't do that we can break systems on upgrade. For example, when removing U-Boot script from device package and replacing it with deviceinfo_generate_extlinux_config="true". The upgrade will remove U-Boot script from the installation, but won't trigger mkinitfs to create extlinux config. This is what I want to be fixed

CC @craftyguy

This should probably trigger on changes (by apk) to the new dir that deviceinfo will live under in /usr/share

...

On July 22, 2023 10:13:13 PM PDT, "jenneron (@jenneron)" gitlab@mg.gitlab.com wrote:

jenneron created an issue: #2228 (closed)

boot-deploy, which is executed by mkinitfs, relies on many stuff from deviceinfo. So, if we modify deviceinfo we need to run mkinitfs

If we don't do that we can break systems on upgrade. For example, when removing U-Boot script from device package and replacing it with deviceinfo_generate_extlinux_config="true". The upgrade will remove U-Boot script from the installation, but won't trigger mkinitfs to create extlinux config. This is what I want to be fixed

CC @craftyguy

By clayton craft on 2023-07-23T06:05:55

mentioned in merge request !4206 (merged)

By jenneron on 2023-07-23T16:18:28

In unl0kr and osk-sdl we trigger mkinitfs as follows, from the APKBUILD:

package() {
# ...
	touch unl0kr
	install -Dm644 unl0kr \
		"$pkgdir"/usr/share/mkinitfs-triggers/unl0kr
# ...
}

So I suggest to fix this as follows:

• create a MR that modifies devicepkg_package.sh (which we call in package() of all device packages) to add an empty file in /usr/share/mkinitfs-triggers/deviceinfo

From there on, all device package changes should cause a trigger of mkinitfs

By Oliver Smith on 2023-07-23T16:32:48

I read over @craftyguy's comment above, this should also work:

This should probably trigger on changes (by apk) to the new dir that deviceinfo will live under in /usr/share

By Oliver Smith on 2023-07-23T16:32:48

What way do we go?

By jenneron on 2023-07-24T04:29:23

As the deviceinfo move to /usr/share migration is still WIP, I'd go with /usr/share/mkinitfs-triggers/deviceinfo to not have it blocked by that.

By Oliver Smith on 2023-07-27T05:52:42

!4169 (merged) is ready to test, and after that I believe there's only one MR left finish the migration though, so maybe we can get it done quite soon and avoid a workaround?

By Pablo Correa Gomez on 2023-07-27T08:05:16

changing where we put the trigger is trivial, I'd rather change it later on than introduce more dependencies on other MRs in this case

By Oliver Smith on 2023-07-31T06:27:05

mentioned in commit 2f01a2ba

By Pablo Correa Gomez on 2023-07-29T13:45:54

mentioned in merge request !4283 (merged)

By Pablo Correa Gomez on 2023-07-29T13:57:27

mentioned in commit a38553d9

By Pablo Correa Gomez on 2023-08-02T17:07:48

mentioned in commit c3b85775

By Pablo Correa Gomez on 2023-08-02T17:07:48

mentioned in commit da75ccc3

By Pablo Correa Gomez on 2023-08-24T18:38:06

mentioned in commit 23614808

By Pablo Correa Gomez on 2023-08-24T18:38:06

mentioned in commit 244bb228

By Pablo Correa Gomez on 2023-08-24T18:50:32

mentioned in commit 8832658b

By Pablo Correa Gomez on 2023-08-24T18:50:33

mentioned in commit 587020cc

By Pablo Correa Gomez on 2023-08-24T18:53:37

mentioned in commit 3e4dbab8

By Pablo Correa Gomez on 2023-08-24T19:13:50

mentioned in commit d990d16c

By Pablo Correa Gomez on 2023-08-24T22:28:10

mentioned in commit b624a030

By Pablo Correa Gomez on 2023-09-08T15:29:16

mentioned in commit 3c02cc1b

By Pablo Correa Gomez on 2023-09-08T15:29:16

mentioned in commit c19b4c52

By Pablo Correa Gomez on 2023-09-18T18:30:00

mentioned in commit 6ee1f405

By Pablo Correa Gomez on 2023-09-18T18:30:00

mentioned in commit 5aedd849

By Pablo Correa Gomez on 2023-09-19T16:13:38

mentioned in commit 98814a98

By Pablo Correa Gomez on 2023-09-19T16:17:05

mentioned in commit 4a4cb7e9

By Pablo Correa Gomez on 2023-09-19T16:17:05

mentioned in commit 7b2208d2

By Pablo Correa Gomez on 2023-09-25T07:21:27

mentioned in commit 1d748a93

By Pablo Correa Gomez on 2023-09-25T07:21:27

closed