CI: Some more fixes + cleanup

Continuation of the CI fixes in !1068 (merged) with some more refactoring.

Keeping this separate since the other MR is a rather "critical" fix and should be merged ASAP. This one is nice to have but not critical at the moment. See commit log for details.

added 6 commits

• acc894cb - device: move .shared-patches to device/.shared-patches
• 3e920fa8 - CI: skip all dot folders for now
• 08064abc - CI: common: get_changed_files: return set, add "removed" parameter
• 40fc9542 - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages()
• f029e824 - CI: common: fixup get_changed_packages()
• bd526eae - test

Compare with previous version

By Minecrell on 2020-03-14T11:55:28

added 3 commits

• 952e9fb7 - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages()
• ad4c4da7 - CI: common: fixup get_changed_packages()
• 2276cdd2 - test

Compare with previous version

By Minecrell on 2020-03-14T11:57:35

marked as a Work In Progress

By Minecrell on 2020-03-14T11:59:01

added 1 commit

• 375fd625 - I like bad APKBUILDs :)

Compare with previous version

By Minecrell on 2020-03-14T12:01:32

unmarked as a Work In Progress

By Minecrell on 2020-03-14T12:10:14

changed the description

By Minecrell on 2020-03-14T12:10:14

changed the description

By Minecrell on 2020-03-14T12:10:29

changed the description

By Minecrell on 2020-03-14T12:10:43

added ci + 1 deleted label

mentioned in commit 195b7a77

By Minecrell on 2020-03-15T14:23:39

mentioned in commit 0eeaa77e

By Minecrell on 2020-03-15T14:23:39

mentioned in commit 940c2754

By Minecrell on 2020-03-15T14:23:39

added 6 commits

• ad4c4da7...796f2d09 - 3 commits from branch master
• 195b7a77 - CI: common: get_changed_files: return set, add "removed" parameter (!1069 (merged))
• 0eeaa77e - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069 (merged))
• 940c2754 - CI: common: fixup get_changed_packages() (!1069 (merged))

Compare with previous version

By Alexey Min on 2020-03-15T14:23:40

2 commits from this MR are in master, so I rebased on master

By Alexey Min on 2020-03-15T14:31:14

resolved all threads

By Alexey Min on 2020-03-20T22:13:28

Changes look good to me. I've also tested this locally and it seems to work, at least in ideal scenarios (no fatal errors during execution), that APKBUILDs in temp/ are skipped. Also verified that other CI scripts affected by common.py change (that call get_changed_packages/get_changed_files) continue to work fine

By Alexey Min on 2020-03-20T22:29:23

approved this merge request

By Alexey Min on 2020-03-20T22:29:38

Excellent patches, thanks a lot @Minecrell!

By Oliver Smith on 2020-03-21T21:25:25

(I stole the device-samsung-golden example for #496 (closed) btw )

By Oliver Smith on 2020-03-21T21:25:55

approved this merge request

By Oliver Smith on 2020-03-21T21:26:08

mentioned in commit 5a8f284d

By Minecrell on 2020-03-21T21:26:52

mentioned in commit 3ab11877

By Minecrell on 2020-03-21T21:26:52

mentioned in commit da903f3f

By Minecrell on 2020-03-21T21:26:52

added 52 commits

• 940c2754...630c9c2a - 49 commits from branch master
• 5a8f284d - CI: common: get_changed_files: return set, add "removed" parameter (!1069 (merged))
• 3ab11877 - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069 (merged))
• da903f3f - CI: common: fixup get_changed_packages() (!1069 (merged))

Compare with previous version

By Oliver Smith on 2020-03-21T21:27:02

enabled an automatic merge when the pipeline for da903f3f succeeds

By Oliver Smith on 2020-03-21T21:27:21

mentioned in commit b96f704b

By Minecrell on 2020-03-21T21:33:29

mentioned in commit 660433a5

By Minecrell on 2020-03-21T21:33:30

mentioned in commit 3200955a

By Oliver Smith on 2020-03-21T21:33:30

mentioned in commit 4e89280a

By Minecrell on 2020-03-21T21:33:30

aborted the automatic merge because source branch was updated

By Oliver Smith on 2020-03-21T21:33:30

added 4 commits

• 3200955a - CI: test_directory_structure.py: fix flake8 (!1069 (merged))
• b96f704b - CI: common: get_changed_files: return set, add "removed" parameter (!1069 (merged))
• 4e89280a - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069 (merged))
• 660433a5 - CI: common: fixup get_changed_packages() (!1069 (merged))

Compare with previous version

By Oliver Smith on 2020-03-21T21:33:31

mentioned in commit e87f2ec2

By Oliver Smith on 2020-03-21T21:36:04

mentioned in commit ae493181

By Minecrell on 2020-03-21T21:36:04

mentioned in commit 0ffb448d

By Minecrell on 2020-03-21T21:36:04

mentioned in commit ff3fbfdb

By Oliver Smith on 2020-03-21T21:36:04

mentioned in commit 87e1b9f0

By Minecrell on 2020-03-21T21:36:04

added 5 commits

• e87f2ec2 - CI: test_directory_structure.py: fix flake8 (!1069 (merged))
• 87e1b9f0 - CI: common: get_changed_files: return set, add "removed" parameter (!1069 (merged))
• ae493181 - CI: apkbuild-linting: use get_changed_files() instead of get_changed_packages() (!1069 (merged))
• 0ffb448d - CI: common: fixup get_changed_packages() (!1069 (merged))
• ff3fbfdb - CI: run flake8 for changes in testcases too (!1069 (merged))

Compare with previous version

By Oliver Smith on 2020-03-21T21:36:06

CI failed at first because of flake8 linting errors that should have been detected in !1070 (merged). I've fixed that and added another trivial commit that should make .gitlab-ci.yml trigger on files in .gitlab-ci/testcases/* too.

By Oliver Smith on 2020-03-21T21:38:19

merged

By Oliver Smith on 2020-03-21T21:38:32