samsung-i9100g: new device

I wonder if it would make sense to merge this with device-samsung-i9100, or if the two devices are just too different despite having a similar code name. I've quickly skimmed through the device page and replicant page and saw that it uses a different GPU.

If it was merged with device-samsung-i9100, it would be done by adding a new kernel subpackage. pmbootstrap will then ask the user which variant they want to use, and we could add the i9100g downstream kernel as variant (and even install i9100g related non-free firmware if the user selects that they want to install firmware).

So, thoughts on merging with the other device port? Could we possibly use the same downstream/mainline kernel?

Thanks for making the merge request, @ungeskriptet!

By Oliver Smith on 2021-09-10T18:11:09

added 2 commits

e2648d10 - 1 commit from branch postmarketOS:master
51230dad - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-10T13:47:01

I've merged the two device packages together and also tested it. The Wi-Fi firmware can be reused for the i9100g since it uses the same Wi-Fi chipset but NetworkManager still doesn't work. Is it okay to install modules-load.conf for i9100g like this?

I'm also trying to get mainline working on it and I think I'm on the right path.

By ungeskriptet on 2021-09-10T14:04:35

added 1 commit

782df870 - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-10T14:01:53

added 1 commit

c87c7678 - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-10T14:07:22

May I ask why you put the i9100g as a separate kernel for i9100? I think it makes more sense to keep them separate packages in case you'd e.g. want to move one of them to community in the future, in addition to that they just are different devices.

By Newbyte on 2021-09-10T18:01:51

added 5 commits

c87c7678...fafc96da - 4 commits from branch postmarketOS:master
6497dd99 - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-11T09:29:20

resolved all threads

By ungeskriptet on 2021-09-11T15:02:10

added 2 commits

8158559a - 1 commit from branch postmarketOS:master
12908f4c - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-11T15:14:28

added 1 commit

af1f6f3c - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-11T15:28:22

added 1 commit

c4faaafa - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-11T15:30:25

added 14 commits

c4faaafa...88e6fb6c - 13 commits from branch postmarketOS:master
521b3732 - samsung-i9100g: new device

Compare with previous version

By ungeskriptet on 2021-09-12T06:18:48

The shellcheck CI failure was unrelated, I'll rebase on 1610a605 to fix it.

Thanks to everybody who take part in the discussion regarding whether it should be a separate device. I agree that this makes more sense.

By Oliver Smith on 2021-09-12T17:03:20

samsung-i9100g: new device

Merge request reports

Activity