samsung-hero: Add the Wifi firmware for the Samsung hero devices

This adds the required firmware to allow ip link set wlan0 up, which then enables Samsung Hero-Devices, the Galaxy S7 (herolte) and the Galaxy S7 Edge (hero2lte), to connect to the Internet.

Does TheMuppets/proprietary_vendor_samsung download the 1.1 Gb archive and only few kilobytes from it are used to create package? Seems highly ineffective

By Alexey Min on 2019-04-11T11:53:39

added 2 commits

• efa10445 - device-samsung-herolte: Specify the actual firmware files
• 819268fe - device-samsung-herolte: Add the final Wifi piece

Compare with previous version

By Alexander on 2019-04-11T11:51:51

added 1 commit

• 723a2998 - device-samsung-herolte: Fix typo in the nvram URL

Compare with previous version

By Alexander on 2019-04-11T11:55:57

added 1 commit

• 1dffcd31 - device-samsung-herolte: Fix typo in the package function

Compare with previous version

By Alexander on 2019-04-11T12:06:02

changed the description

By Alexander on 2019-04-11T12:10:10

Thanks for the patch @Polynomdivision!

Let us know with a comment, when it's ready (no e-mails get sent when pushing commits), looking forward to it

By Oliver Smith on 2019-04-11T22:33:22

added 1 commit

• 8bab16f8 - device-samsung-herolte: Install firmware to its pmOS location

Compare with previous version

By Alexander on 2019-04-13T11:05:12

@ollieparanoid This MR can be merged after !316 (merged) has been merged. Just so that the commit history makes sense

By Alexander on 2019-04-13T11:08:08

unmarked as a Work In Progress

By Alexander on 2019-04-13T11:58:54

changed title from WIP: Add the Wifi firmware for the Samsung hero devices to samsung-hero Add the Wifi firmware for the Samsung hero devices

By Alexander on 2019-04-13T11:58:54

changed the description

By Alexander on 2019-04-13T12:00:08

changed title from samsung-hero Add the Wifi firmware for the Samsung hero devices to samsung-hero: Add the Wifi firmware for the Samsung hero devices

By Alexander on 2019-04-13T12:00:25

added 1 commit

• 94e900ef - firmware-samsung-hero: Remove 'Maintainer' comment

Compare with previous version

By Alexander on 2019-04-15T19:24:58

added 25 commits

• 94e900ef...9353bca7 - 24 commits from branch postmarketOS:master
• 548e9465 - samsung-herolte: add wifi firmware (!309 (merged))

Compare with previous version

By Oliver Smith on 2019-04-18T21:10:40

resolved all discussions

By Oliver Smith on 2019-04-18T21:11:24

The patch looks good now. I forgot to mention this earlier, but I recommend to also modify the device specific packages, so pmbootstrap init asks the user if they want to install this firmware package:

https://wiki.postmarketos.org/wiki/Device_specific_package#Proprietary_firmware_or_userland_blobs

Do you want to do this in a follow up MR?

I've decided to merge this one as-is, because it already went through a few iterations, and it is working on its own (as long as the user manually installs the package).

Thanks again @Polynomdivision!

By Oliver Smith on 2019-04-18T21:14:18

approved this merge request

By Oliver Smith on 2019-04-18T21:14:36

resolved all discussions

By Oliver Smith on 2019-04-18T21:14:43

merged

By Oliver Smith on 2019-04-18T21:14:55