postmarketos-fde-unlocker: make unl0kr the default

I'll need some more time to test this. Have been fighting severe network issues this evening so this is just a blind patch so far.

Fixes: #1411 (closed)

TODO:

• https://gitlab.com/cherrypicker/unl0kr/-/issues/34
• https://gitlab.com/cherrypicker/unl0kr/-/issues/36 (at least good enough)
• new unl0kr version in pmaports with fixes for the above issues
• !3777 (closed)

I tested building a new image with this patch (pmbootstrap install --fde), and unl0kr was selected by default. so that looks good.

It also looks like unl0kr isn't replacing osk-sdl on existing installations, which I think is the right thing to do for now...

Later on when osk-sdl is dropped from the repo we can test that apk correctly selects unl0kr and not the 'no-fde' virtual package that is a lower priority.

By clayton craft on 2022-07-09T15:13:49

added type::feature label

approved this merge request

By Oliver Smith on 2022-07-13T06:44:29

Diff looks good. Thanks @cherrypicker!

By Oliver Smith on 2023-10-03T19:58:45

Thanks all, especially @calebccff! Was quite the way to get here in the end.

By Johannes Marbach on 2023-10-03T19:58:45

approved this merge request

By Dylan Van Assche on 2022-07-16T11:06:19

Works fine on SHIFT6mq

By Dylan Van Assche on 2022-07-18T12:58:54

I'm keeping this as a "draft" until we have some consensus in #1411 (closed) that all community and main devices are working OK with it

By clayton craft on 2023-10-03T19:14:47

added 1 deleted label

Sorry to bother you @cherrypicker,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

Thanks for your contribution.

By * postmarketOS Bot on 2022-08-21T04:00:01

removed 1 deleted label

Can we avoid initramfs being 7.7M size? Some devices have only 8 MiB boot partition

/ # ls -lh /boot/initramfs
-rw-r--r--    1 root     root        7.7M Oct  3 04:30 /boot/initramfs

It is 3.6M with osk-sdl:

/ # ls -lh /boot/initramfs
-rw-r--r--    1 root     root        3.6M Oct  3 04:45 /boot/initramfs

By jenneron on 2022-10-03T08:30:05

added status::mr-stale label

Sorry to bother you @cherrypicker,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

Thanks for your contribution.

By * postmarketOS Bot on 2022-11-15T19:00:02

removed status::mr-stale label

added status::mr-stale label

Sorry to bother you @cherrypicker,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping @postmarketOS. You can also ask on matrix in #devel:postmarketos.org or #postmarketos-devel on OFTC. If no further activity occurs in this MR, postmarketOS developers may close it in the future.

Thanks for your contribution.

By * postmarketOS Bot on 2022-12-16T06:00:04

changed milestone to %v23.06 Release

I added this to the v23.06 milestone because I'd really like to deprecate / remove osk-sdl and make unl0kr the default. Not only is it a much better app, but the dependencies are very light, and removing osk-sdl would let me simplify a lot of the mkinitfs code...

By clayton craft on 2023-01-02T20:05:39

added 663 commits

• d94ff73d...9183be33 - 662 commits from branch postmarketOS:master
• 97068e4d - postmarketos-fde-unlocker: make unl0kr the default (MR 3279)

Compare with previous version

By clayton craft on 2022-12-20T20:33:58

changed the description

By clayton craft on 2023-01-05T22:03:07

changed the description

By clayton craft on 2023-01-05T22:03:43

changed the description

By clayton craft on 2023-01-05T22:04:43

changed the description

By clayton craft on 2023-01-05T22:04:54

mentioned in merge request !3777 (closed)

By Dylan Van Assche on 2023-01-08T14:23:54

marked the checklist item !3777 (closed) as completed

By clayton craft on 2023-01-08T19:10:20

Removing milestone, see #1411 (comment 1402459448)

By Oliver Smith on 2023-05-23T21:06:42

removed milestone %v23.06 Release

@cherrypicker do you think we can mark this as "ready"?

By clayton craft on 2023-10-02T21:27:28

marked the checklist item https://gitlab.com/cherrypicker/unl0kr/-/issues/34 as completed

By clayton craft on 2023-09-27T06:15:53

added 1132 commits

• 97068e4d...953e7464 - 1131 commits from branch postmarketOS:master
• 24e6b25d - postmarketos-fde-unlocker: make unl0kr the default (MR 3279)

Compare with previous version

By clayton craft on 2023-10-02T05:04:27

marked this merge request as ready

By Johannes Marbach on 2023-10-02T10:49:53

marked the checklist item new unl0kr version in pmaports with fixes for the above issues as completed

By Johannes Marbach on 2023-10-02T10:50:55

I would like to do a few smoke tests before approving / merging this

By clayton craft on 2023-10-03T19:05:38

removed status::mr-stale label

So happy to have this finally land. Well done everybody, and especially @cherrypicker!

By Oliver Smith on 2023-10-03T19:13:40

added 14 commits

• 24e6b25d...52fbd2f2 - 13 commits from branch postmarketOS:master
• 828aac0e - postmarketos-fde-unlocker: make unl0kr the default (MR 3279)

Compare with previous version

By Oliver Smith on 2023-10-03T19:07:50

mentioned in issue #1411 (closed)

By Oliver Smith on 2023-10-03T19:13:11

approved this merge request

By clayton craft on 2023-10-03T19:13:43

resolved all threads

By Oliver Smith on 2023-10-03T19:14:47

merged

mentioned in merge request postmarketos.org!231 (merged)

By Oliver Smith on 2023-10-03T19:56:49

mentioned in issue #2319 (closed)

By Oliver Smith on 2023-10-03T20:05:20