unl0kr testing for community and main devices

changed the description

By clayton craft on 2022-02-04T01:10:02

ODROID-HC2 doesn't have a display... FDE was never really 'tested' with osk-sdl. It probably just works with cryptsetup over serial, but using it like that is horrible.

Marked ODROID-HC2 as 'done'

By Dylan Van Assche on 2022-02-05T20:16:00

marked the checklist item odroid-hc2 (@dylanvanassche ) as completed

By Dylan Van Assche on 2022-02-04T07:30:24

marked the checklist item pine64-pinephone (@MartijnBraam @z3ntu @PureTryOut @dylanvanassche ) as completed

By Dylan Van Assche on 2022-02-04T07:30:31

samsung-gt58 works fine, can handle the funny aspect ratio. Would expect all other msm8916 devices to work as well.

Interestingly, mkinitfs said:

...
2022/02/04 15:56:59 == Generating initramfs extra ==
2022/02/04 15:56:59 - Including extra binaries
2022/02/04 15:56:59 - *NOT* including FDE support
...

By Nikita Travkin on 2022-02-05T20:15:57

@craftyguy had also raised the mkinitfs output here. If I understand correctly, this has to stick around for now though.

By Johannes Marbach on 2022-02-04T17:57:12

yeah it's probably best to just clean up the confusing mkinitfs message once we pull osk-sdl, to avoid having to make multiple possibly-risky changes to the initfs stuff.

By clayton craft on 2022-02-04T19:10:20

Nokia N900:

unlocks fine with hardware keyboard
unable to unlock with vkb, as keyboard is not correctly mapped to the touchscreen, i.e. seems to be inverted about the center
- the keys are rather small. one will need to type slowly or use the stylus. if the top bar could be reduced in size, the keys could possibly become a more comfortable size

By Sicelo on 2022-02-05T20:15:54

Thanks for testing @sicelo.

The N900's display is 800x480 pixels, right? Does the UI generally look like in this screenshot?

The "breezy" theme has a little less padding than the default pmOS theme which results in slightly larger keys. Maybe we could decrease the padding in the pmOS theme as well. CC @dylanvanassche

About the touch screen, is it just the on-screen keyboard that doesn't properly register touches or all of the UI? And when you say "inverted about the center" does that mean you tap at (midX + x, midY + y) and the touch is registered at (midX - x, midY - y)?

By Johannes Marbach on 2022-02-05T20:15:46

@sicelo thanks for testing. the touch input issue sounds like maybe a calibration problem, and the input driver used by unl0kr/lvgl probably needs some info to correct it. in osk-sdl, tslib is used for input, and can accept calibration info to adjust input accordingly.

By clayton craft on 2022-02-04T19:29:44

display is 800x480 yes, with 3.5" diagonal. So the more space keyboard can be allocated, the better.

touch screen, in the pmos theme, the touch is inverted around that green horizontal line running through the screen. i.e. if you click around the 'backspace' or 'Enter' key, you're actually activating the power 'button'. when you try to change theme (dark/light), you actually activate Shift or the 123 button

By Sicelo on 2022-02-04T19:36:32

@cherrypicker Feel free to adjust the theme to make it fit nicely on these devices as well :)

By Dylan Van Assche on 2022-02-04T19:41:00

I created upstream issues for the touchscreen and key size: https://gitlab.com/cherrypicker/unl0kr/-/issues/29, https://gitlab.com/cherrypicker/unl0kr/-/issues/30

The touchscreen issue sounds similar to this older GitHub issue but I will have to do more digging.

By Johannes Marbach on 2022-02-05T19:45:17

The touchscreen registers touch properly once booted to the desktop environment. The correct calibration is already available in the device package - https://gitlab.postmarketos.org/postmarketos/pmaports/-/blob/master/device/community/device-nokia-n900/udev/90-touchscreen-dev.rules

So somehow unl0kr just needs to use that. No idea if udev is up by that time.

By Sicelo on 2022-02-05T20:03:30

Aha! I think we're on to something here.

Unl0kr uses libinput which in turn uses udev. The rules are copied into the initfs but only from /lib/udev/rules.d/. It looks like the rules you mentioned are in /etc/udev/rules.d/ though.

I didn't realize there was another rules directory, sorry.

But chances are we'll just have to copy all the rules from this folder, too.

By Johannes Marbach on 2022-02-05T20:05:46

@cherrypicker Yes, with that udev rule added, I can unlock the N900 with touchscreen. I believe you'll add it to the package

So @craftyguy , N900 can be marked as done.

By Sicelo on 2022-02-05T23:36:07

Neat! I already opened https://gitlab.postmarketos.org/postmarketos/pmaports/-/merge_requests/2911 to fix it in the unl0kr package. Thanks for helping track this down!

By Johannes Marbach on 2022-02-05T20:31:42

Pine64 Pinetab:

Works as expected. Rotated 90° to the right (portrait mode) whereas the splash screen is landscape mode.

By Hendrik Borghorst on 2022-02-05T20:15:40

Thanks for testing, @djselbeck!

Unl0kr is currently using the orientation reported by the framebuffer itself. It looks like for the Pinetab we explicitly specify deviceinfo_framebuffer_landscape="true" which is then evaluated when generating the splash image.

I guess to make unl0kr use the same orientation it'd need a dedicated CLI argument which is then set based on the value of deviceinfo_framebuffer_landscape.

@craftyguy WDYT?

By Johannes Marbach on 2022-02-05T20:14:30

@calebccff how does your new splash app handle orientation?

By clayton craft on 2022-02-05T23:52:22

Xiaomi Mi Note 2 (xiaomi-scorpio):

Doesn't receive input neither from the touchscreen nor a USB keyboard.

I thought this would close #1268 (closed), but it looks like it won't be as easy as I expected. I'll try to find out what's wrong. It would be great if someone has an idea on where I should start looking.

By Yassine Oudjana on 2022-02-05T20:15:38

Thanks for testing @Tooniis! And sorry it doesn't seem to work at all.

Unl0kr uses libinput for reading from /dev/input/event... nodes for both hardware keyboards and the touchscreen. I think the first thing to try is running something like evtest in the debug shell to see what event nodes are there and then checking which ones unl0kr picked (which should be logged to STDERR).

I have never actually debugged unl0kr in the debug shell myself though so I'd have to try this out, too.

By Johannes Marbach on 2022-02-05T20:10:57

This device doesn't have any udev rules in /etc/udev/rules.d, does it? Just asking because those files are currently not yet copied into the initfs (see #1411 (comment 832955979)).

By Johannes Marbach on 2022-02-05T20:12:36

@Tooniis we recently merged a fix to correctly set up udev in the initfs (!3146 (merged)) which may help address your issue.

By Johannes Marbach on 2022-05-31T19:24:09

Looks like that was enough to fix it. Touch input works now.

By Yassine Oudjana on 2022-07-09T15:14:31

Tested on samsung-serranove using on-screen keyboard and a rather simple passphrase - worked very well for me. High-contrast mode and showing password worked fine as well.

@Minecrell fyi

By Daniel Kulesz on 2022-02-05T20:25:19

marked the checklist item samsung-serranove (@Minecrell ) as completed

By clayton craft on 2022-02-05T18:59:31

marked the checklist item samsung-gt58 (@TravMurav) as completed

By clayton craft on 2022-02-05T18:59:33

changed the description

By clayton craft on 2022-02-05T19:02:19

marked the checklist item nokia-n900 (@sicelo @MartijnBraam @danct12) as completed

By clayton craft on 2022-02-05T23:36:00

tested on the pinebook pro, the UI size was fine (osk hidden by default because it found the physical keyboard as expected)

the only real problem I found was that it wasn't registering key presses when I typed 'normally'. I had to type my passphrase slowly/deliberately for all the presses to register correctly. @cherrypicker have you seen this in your testing?

By clayton craft on 2022-02-08T06:39:24

Hm, I did see key presses being dropped occasionally when testing it with my Ergodox EZ but only with the dual function keys (where the trigger time is longer than with normal keys). The key handling happens within LVGL. I wonder if maybe it's not able to keep up with the events due to load.

I put in an issue here for further investigation: https://gitlab.com/cherrypicker/unl0kr/-/issues/31.

By Johannes Marbach on 2022-02-08T18:28:48

mentioned in commit 580ed15d

By Johannes Marbach on 2022-02-09T18:46:11

For samsung-espresso3g, as unl0kr is added to initramfs, the boot.img becomes bigger than the boot partition so until it is moved to initramfs-extra, cannot test it/

By Mighty on 2022-03-30T07:00:05

ya basically I think postmarketos-mkinitfs should have a directory for collecting lists of files that should be installed in the -extra archive. then unl0kr's package could add its list file to that dir.

By clayton craft on 2022-03-30T07:00:05

https://gitlab.com/postmarketOS/postmarketos-mkinitfs/-/issues/11

By clayton craft on 2022-03-30T07:10:15

Ah nice you already made a MR as well thanks!

By Mighty on 2022-03-31T06:43:18

@MightyM17 can you verify that this is no longer an issue for you when using unl0kr?

By clayton craft on 2022-07-07T16:58:02

Did a fresh build on edge and the boot.img I get is of 11mb, so it still seems to be an issue. Reason being MR#19 has those changes and we need to create a new release as pmaports uses 1.4.1 which doesnt include it

By Mighty on 2022-07-10T06:46:21

Installed unl0kr on a running device with apk and that works fine, here's the log

samsung-espresso3g:~$ sudo unl0kr
[sudo] password for user:
unable to add device to libinput context: No such file or directory
libinput error: event1  - MELFAS MMS136 Touchscreen: client bug: event processing lagging behind by 29ms, your system is too slow
libinput error: event1  - MELFAS MMS136 Touchscreen: client bug: event processing lagging behind by 26ms, your system is too slow
libinput error: event1  - MELFAS MMS136 Touchscreen: client bug: event processing lagging behind by 29ms, your system is too slow
libinput error: event1  - MELFAS MMS136 Touchscreen: client bug: event processing lagging behind by 33ms, your system is too slow
libinput error: event1  - MELFAS MMS136 Touchscreen: client bug: event processing lagging behind by 29ms, your system is too slow
libinput error: event1  - MELFAS MMS136 Touchscreen: WARNING: log rate limit exceeded (5 msgs per 60min). Discarding future messages.
147147

Everything from input to themes works perfectly fine.

By Mighty on 2022-07-10T06:39:58

Great!

Reason being MR#19 has those changes and we need to create a new release as pmaports uses 1.4.1 which doesnt include it

I suppose we'll also need a new version of the unl0kr package that actually puts its files hook file into the extra directory?

By Johannes Marbach on 2022-07-10T08:37:15

I suppose we'll also need a new version of the unl0kr package that actually puts its files hook file into the extra directory?

We can just define it in /etc/postmarketos-mkinitfs/files-extra as the MR suggests and it should work. There's no need of making changes in unl0kr from what I understand.

By Mighty on 2022-07-10T08:39:46

mentioned in issue postmarketos-mkinitfs#11 (closed)

By clayton craft on 2022-03-30T07:09:56

@cherrypicker I tried this in qemu, and input seems to be broken, I get these messages in the kernel log... IIRC vaguely that you mentioned something like this before but I don't remember what the fix was, or if this is even exactly what you mentioned, heh.

libinput error: libinput bug: udev device never initialized (/dev/input/event1)

By clayton craft on 2022-03-31T17:04:38

I checked our Matrix conversation from last year and that seems like what I was seeing, too:

libinput error: libinput bug: udev device never initialized (/dev/input/event0)
libinput error: client bug: Invalid path /dev/input/event0
unable to add device to libinput context: No such file or directory

The fix I made back then is this which still seems to be in place. I'm not for sure why this could have stopped working.

By Johannes Marbach on 2022-03-31T17:04:37

Adding further context from a private conversation: Running udevadm / unl0kr manually from the debug shell worked for @craftyguy so this smells like a timing issue during boot. Adding a 5s delay before and after the udevadm call in init_functions did not help though. I'm unable to reproduce the issue at all in Qemu on my laptop so far.

By Johannes Marbach on 2022-05-21T18:36:55

PBP looks good now with !3146 (merged)

By clayton craft on 2022-05-29T19:09:31

Great! I think the MR accidentally closed this issue though?

By Johannes Marbach on 2022-05-29T19:21:04

oops, re-opened it

By clayton craft on 2022-05-29T19:47:50

@craftyguy in the aftermath of fixing this issue I fleshed out https://wiki.postmarketos.org/wiki/Unl0kr a little more and added a section for how to debug input devices. Maybe we could add the link to this page in the issue description?

By Johannes Marbach on 2022-07-07T16:56:54

mentioned in merge request !3146 (merged)

By Johannes Marbach on 2022-05-22T12:06:36

closed

mentioned in commit a0ba3764

By Johannes Marbach on 2022-05-29T19:08:12

marked the checklist item pine64-pinebookpro (@craftyguy @minlexx ) as completed

By clayton craft on 2022-05-29T19:09:03

reopened

mentioned in commit aa0f96ed

By Johannes Marbach on 2022-05-31T07:24:00

changed the description

By Alexey Min on 2022-06-01T17:16:51

marked the checklist item xiaomi-scorpio (@tooniis) as completed

By Alexey Min on 2022-07-07T09:09:08

Works fine on Smasung Galaxy A5 2015 (a5lte, SM-A500F)

By Alexey Min on 2022-07-09T15:15:35

marked the checklist item samsung-a5 (@Minecrell @minlexx ) as completed

By Alexey Min on 2022-07-07T10:10:59

changed the description

By clayton craft on 2022-07-07T16:56:19

mentioned in merge request !3279 (merged)

By Johannes Marbach on 2022-07-07T19:59:34

@Extension-Driver is there any chance you could test this on samsung-m0? I won't be able to use mine until late next month.

By Newbyte on 2022-07-08T03:24:00

@cherrypicker Does not seem to work on asus-me176c sadly. Nothing shows up at all. It looks like it cannot handle very simple framebuffer drivers like efifb or simplefb that do not implement FBIOBLANK. When running it from debug-shell I get:

unl0kr 0.1.0
Found theme: pmos-dark
Found theme: pmos-light
ioctl(FBIOBLANK): Invalid argument
Connecting touchscreen device /dev/input/event0
<weird permanent touchscreen spam but likely unrelated>

When I start it outside of initramfs it works fine, but it's a different situation since then the Intel display driver is loaded.

I guess https://github.com/lvgl/lv_drivers/blob/master/display/fbdev.c#L101-L105 shouldn't return completely just because the FBIOBLANK fails?

By Minecrell on 2022-07-08T11:21:12

Oh, nice find! I opened a PR upstream to not return. Will report back once this ready to test again.

Stupid question: Is there a way that I could test one of these drivers without having a device?

Tracking the issue in https://gitlab.com/cherrypicker/unl0kr/-/issues/35

By Johannes Marbach on 2022-07-09T15:57:51

This should now be fixed with !3366 (merged).

By Johannes Marbach on 2022-08-18T18:05:58

I've just tried it on Oneplus 6T (fajita). During booting, after pmOS logo I only see black screen and nothing else, though phone can be pinged over USB.

When I click the place where "Enter" button is supposed to be, screen refreshes once and goes black again. I can repeat pressing "OK" again after some time, and I see the same - single frame drawn, followed by black screen.

oneplus-fajita-unl0kr

By Alexey Min on 2022-07-08T12:21:53

I don't see anything really suspicious when running unl0kr from debug-shell

/ # find_root_partition
/dev/mapper/sda14p2
/ # CRYPTTAB_SOURCE=/dev/mapper/sda14p2 CRYPTTAB_TRIED=0 unl0kr -v
unl0kr 0.1.0
Found theme: pmos-dark
Found theme: pmos-light
unable to add device to libinput context: No such file or directory
unable to add device to libinput context: No such file or directory
Connecting touchscreen device /dev/input/event3
libinput error: event3  - Synaptics S3706B: client bug: event processing lagging behind by 29ms, your system is too slow
libinput error: event3  - Synaptics S3706B: client bug: event processing lagging behind by 31ms, your system is too slow
libinput error: event3  - Synaptics S3706B: client bug: event processing lagging behind by 32ms, your system is too slow
libinput error: event3  - Synaptics S3706B: client bug: event processing lagging behind by 25ms, your system is too slow
libinput error: event3  - Synaptics S3706B: client bug: event processing lagging behind by 26ms, your system is too slow
libinput error: event3  - Synaptics S3706B: WARNING: log rate limit exceeded (5 msgs per 60min). Discarding future messages.
edfcgyvc

I see the same result, as soon as unl0kr starts, screen goes black. I tried to randomly tab buttons on the invisible keyboard, then pressed "Enter" on bottom right corner, and I guess "edfcgyvc" on stdout is what I typed blindly.

P.S. framebuffer driver is

# cat /sys/class/graphics/fb0/name 
msmdrmfb

By Alexey Min on 2022-07-08T13:28:39

Just gave it a spin on my OnePlus 6 and it seemed to work fine, looks great! The scaling is a bit off, animations are very laggy and the key-popup doesn't always appear when typing fast, but nothing making it unusable.

I just installed it, stopped tinydm and ran it manually over SSH.

@cherrypicker can scaling be configured per-device?

By Caleb Connolly on 2022-07-08T14:13:49

@cherrypicker can scaling be configured per-device?

I've made a change recently that uses the screen's DPI value for measurements which might help a little. That's not yet included in the pmOS package though.

The textarea / disclosure button container is set to scale up to at most 512 pixels. It looks like that's not enough maybe. Unfortunately, my laptop's resolution is lower than the device's resolution, so I'll have to think about how to test this.

Logged https://gitlab.com/cherrypicker/unl0kr/-/issues/33 to track this.

By Johannes Marbach on 2022-07-09T15:52:43

@minlexx that's really odd. Sounds like maybe something is off in the LVGL fbdev driver.

Any idea how I could test msmdrmfb without having a One Plus 6T?

I've logged https://gitlab.com/cherrypicker/unl0kr/-/issues/34 to track this

By Johannes Marbach on 2022-07-09T15:56:19

@cherrypicker hmm maybe you could run it in qemu and then just scale down the qemu window?

regarding the 6T, the only difference between it and the OnePlus 6 is the resolution and some stuff in the panel driver. theres some quirks with it which i guess are coming in to play here.

By Caleb Connolly on 2022-07-09T16:16:25

Same on SHIFT6mq. Everything else works :)

By Dylan Van Assche on 2022-07-18T13:18:33

Same on SHIFT6mq. Everything else works

@dylanvanassche same bug as on fajita? Or works OK as on enchilada?

By Alexey Min on 2022-07-28T02:58:56

Like on enchilada (scaling)

By Dylan Van Assche on 2022-07-28T13:36:37

Pinephone with Keyboard attachment works great. It shows up in portrait mode and the virtual keyboard does not appear, just like osk-sdl does currently.

By Adam Thiede on 2022-08-18T18:05:36

changed the description

By Dylan Van Assche on 2022-07-18T13:17:48

mentioned in issue #1618 (closed)

By Oliver Smith on 2022-07-21T06:36:26

marked the checklist item oneplus-enchilada (@calebccff ) as completed

By Dylan Van Assche on 2022-07-31T13:40:39

marked the checklist item oneplus-fajita (@calebccff) as completed

By Dylan Van Assche on 2022-07-31T13:40:41

marked the checklist item samsung-espresso3g (@MightyM17 @antoni.aloytorrens) as completed

By Dylan Van Assche on 2022-07-31T13:41:09

marked the checklist item oneplus-fajita (@calebccff) as incomplete

By Dylan Van Assche on 2022-07-31T13:43:36

mentioned in merge request !3366 (merged)

By Johannes Marbach on 2022-08-17T14:46:13

changed milestone to %v23.06 Release

unl0kr testing for community and main devices

Steps

Devices to test:

Child items ...

Activity