exynos5420 tablets: fix so that xorg based UIs work again

Same fix as for samsung-crownlte in !3827 (merged).

Same fix as applied to samsung-dream and samsung-gts210lte in !4459 (closed) and !4460 (closed).

Many (samsung only?) devices needs this fix.

changed title from device-samsung-chagallwifi: fix so that xorg based UIs work again to exynos5420 tablets: fix so that xorg based UIs work again

By Henrik Grimler on 2023-10-08T09:15:20

added 3 commits

• 8c89a74b - device-samsung-klimtlte: fix so that xorg based UIs work again
• fb153d85 - device-samsung-n1awifi: fix so that xorg based UIs work again
• 3fbb8bff - device-samsung-v1awifi: fix so that xorg based UIs work again

Compare with previous version

By Henrik Grimler on 2023-10-08T09:16:54

approved this merge request

By Alexey Min on 2023-10-08T10:28:30

Shouldn't we instead include this file directly into postmarketos-base with the same install_if as here? Basically to safe you and other future people work? Or do you see some problem with that approach?

By Pablo Correa Gomez on 2023-10-08T18:23:30

Adding it for all devices with vendor kernels would be nice, but I don't think we have a good way to determine if kernel is close-to-mainline or based on vendor sources. Alternatively, maybe adding a "samsung-downstream" package that has a subpackage with this file and install_if=xorg-server makes sense, and all samsung devices with vendor kernels could den depend on.

For chagallwifi and klimtlte, who has option for both downstream and mainline, I will change to install_if="$pkgname=$pkgver-r$pkgrel $pkgname-kernel-downstream xorg-server" in this MR at least

By Henrik Grimler on 2023-10-08T18:23:30

Thank you very much for creating the merge requests.

Adding it for all devices with vendor kernels would be nice, but I don't think we have a good way to determine if kernel is close-to-mainline or based on vendor sources.

We could add a postmarketos-base-downstream package, and let device packages using downstream kernels depend on it. (You don't need to add it to all downstream ports if you introduce the package if it is too much work, that could be done in a separate MR.)

Alternatively, maybe adding a "samsung-downstream" package that has a subpackage with this file and install_if=xorg-server makes sense, and all samsung devices with vendor kernels could den depend on.

I think having a shared package of some sort would be much better here, as you mentioned probably a lot of devices will be affected. Then we only need to add one depends line for affected devices instead of adding the same config to each port. As we don't know if it only affects samsung devices, it's probably a good idea not to put samsung in the name.

By Oliver Smith on 2023-10-09T04:40:49

We could add a postmarketos-base-downstream package, and let device packages using downstream kernels depend on it

Package or subpackage of postmarketos-base? It seems like it might be only Samsung devices that have this issue (I haven't seen a report for a non-samsung device at least), but I guess it is fine to add the fix to all devices using downstream kernels, since we basically just revert https://github.com/canonical/lightdm/commit/77a7c6b7b8ca896b98ef43826641bdd520650bfb.

By Henrik Grimler on 2023-10-09T19:22:19

Given that we already have several postmarketos-base-* packages, I'd say make a separate package.

Package or subpackage of postmarketos-base? It seems like it might be only Samsung devices that have this issue (I haven't seen a report for a non-samsung device at least), but I guess it is fine to add the fix to all devices using downstream kernels, since we basically just revert https://github.com/canonical/lightdm/commit/77a7c6b7b8ca896b98ef43826641bdd520650bfb.

By Oliver Smith on 2023-10-10T07:35:45

Started looking at it. I am lazy so will look for kernels with versions older than 5, and then add the dependency to device packages that depend on that kernel.

Hopefully there won't be too many false positives or too many missing devices. Currently I have 295 device packages that need modification.

By Henrik Grimler on 2023-10-16T20:05:02

Please don't do these assumption based on kernel version, there's also msm-5.4, msm-5.10 and msm-5.15 downstream kernels, soon probably msm-6.1. And these probably also do weird things and are for sure not mainline kernels

By Luca Weiss on 2023-10-18T17:15:42

@z3ntu Great, I'll make sure to add those kernels to the list as well! Do you know a better way to detect which kernels are downstream based rather than version? I think version < 5 catches most of them, and the exceptions (like msm-{5,6}*) can then be handled manually

By Henrik Grimler on 2023-10-19T06:35:20

As written above:

(You don't need to add it to all downstream ports if you introduce the package if it is too much work, that could be done in a separate MR.)

Let's rather finish this up with just a few devices, and then we can do additional MRs to let devices depend on it that need it.

By Oliver Smith on 2023-10-19T06:46:35

Alright, proposal in !4497 (merged).

By Henrik Grimler on 2023-10-20T07:52:34

@pabloyoyoista it is "true" by default for a reason https://github.com/canonical/lightdm/commit/77a7c6b7b8ca896b98ef43826641bdd520650bfb

By jenneron on 2023-10-10T07:55:19

added 4 commits

• 5c8b6aca - device-samsung-chagallwifi: fix so that xorg based UIs work again
• 4978a257 - device-samsung-klimtlte: fix so that xorg based UIs work again
• d585a996 - device-samsung-n1awifi: fix so that xorg based UIs work again
• cc75c323 - device-samsung-v1awifi: fix so that xorg based UIs work again

Compare with previous version

By Henrik Grimler on 2023-10-08T18:29:45

mentioned in merge request !4459 (closed)

By Oliver Smith on 2023-10-09T04:41:15

mentioned in merge request !4460 (closed)

By Oliver Smith on 2023-10-09T04:41:21

added 12 commits

• cc75c323...82b139a6 - 8 commits from branch postmarketOS:master
• 2b268d14 - device-samsung-chagallwifi: fix so that xorg based UIs work again
• 4ed51ecf - device-samsung-klimtlte: fix so that xorg based UIs work again
• 98bd8e52 - device-samsung-n1awifi: fix so that xorg based UIs work again
• b6bdff17 - device-samsung-v1awifi: fix so that xorg based UIs work again

Compare with previous version

By Henrik Grimler on 2023-10-09T19:24:42

mentioned in merge request !4492 (closed)

By Pablo Correa Gomez on 2023-10-18T10:21:02

mentioned in merge request !4491 (closed)

By Pablo Correa Gomez on 2023-10-18T10:22:21

mentioned in merge request !4497 (merged)

By Henrik Grimler on 2023-10-20T07:48:09

Closing in favour of !4497 (merged).

By Henrik Grimler on 2023-10-20T07:52:44

closed