As suggested by Robert Mader in issue 57, thanks.

Thanks to plata-gl for pointing this out. Fix #61.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

This fixes one of the issues from #52, but I have not been able to
reproduce the others on Phosh.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Since Firefox 104 the Services global is available automatically and no
longer needs to be imported, and since Firefox 117 importing it is an
error.

Previously the Firefox version would be detected as 0 on the first
start, causing popups.before-ff-108.css to be included even on newer
versions, which breaks touch input.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Firefox 113 changes from 'display: -moz-box' to 'display: flex', so the
-moz-box-flex property should be changed to flex-grow. However, that
breaks the tab menu, and it doesn't seem to be necessary anyway.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Without this fix, the tab menu is only tall enough for 2 or 3 entries.

This is an update of the rule directly above it, changing the ID and
changing from a calculated height to a fixed height matching its child
#allTabsMenu-allTabsView. With the calculated height, the menu entries
were offset above the top of the menu. The previous rule no longer seems
to be necessary, at least in Firefox 102 and newer, since
#allTabsMenu-multiView does not exist.

Ulrik de Muelenaere authored 1 year ago and Oliver Smith committed 1 year ago

Firefox 113 changes from 'display: -moz-box' to 'display: flex', so we
need to use the order property instead of -moz-box-ordinal-group.

On first start, only restart Firefox once after the files are
installed.

[2023-04-18 07:07:05] Running mobile-config-autoconfig.js
[2023-04-18 07:07:05] Couldn't get Firefox version (expected on first start): TypeError: Services.appinfo.lastAppVersion is null
[2023-04-18 07:07:05] Firefox version: 0 (previous: unknown)
[2023-04-18 07:07:05] Creating CSS file from fragments: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userChrome.css
…
[2023-04-18 07:07:05] Updating previous Firefox version to: 0
[2023-04-18 07:07:05] Triggering Firefox restart
[2023-04-18 07:07:05] Done
[2023-04-18 07:07:11] Running mobile-config-autoconfig.js
[2023-04-18 07:07:11] Firefox version: 102 (previous: 0)
[2023-04-18 07:07:11] Reading fragments from file: /etc/mobile-config-firefox/userChrome.files
[2023-04-18 07:07:11] Fragment with FF version check included: userChrome/popups.before-ff-108.css
[2023-04-18 07:07:11] File is up-to-date: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userChrome.css
[2023-04-18 07:07:11] Reading fragments from file: /etc/mobile-config-firefox/userContent.files
[2023-04-18 07:07:11] File is up-to-date: /home/user/.mozilla/firefox/ah7sid6m.default-release/chrome/userContent.css
[2023-04-18 07:07:11] Updating previous Firefox version to: 102
[2023-04-18 07:07:11] Setting default preferences
[2023-04-18 07:07:11] Done

Refactor the condition code, so it's easier to read.

On first run / after:
$ rm ~/.mozilla

The function fails with:
TypeError: Services.appinfo.lastAppVersion is null

Expect the failure so the script doesn't crash.
Revert "autoconfig: get_firefox_version: remove try…catch", but
with another error message.

Without this patch an error shows up when starting Firefox with the
config, until the user manually starts it again.

This reverts commit 2405aabd.

Make the bookmarks panel usable again by hiding all controls except for
the name, the "show editor when saving" checkbox and the remove bookmark
/ save buttons.

This part is unrelated to generating the CSS files, so move it towards
the end.

There is a try…catch around main() now, which logs the exception and
fails with an error that is visible for the user.

Don't regenerate the firefox config if a part of the version changed
that isn't the major version as this would just lead to needless
regernations and slightly delayed startup.

Split the #mainPopupSet CSS rule to an extra file
popups.before-ff-108.css, and adjust autoconfig.js to skip that file if
firefox is newer than >= 108.

Make debugging easier by printing exceptions to the log. For example:

  main() failed: TypeError: fragment.contains is not a function

Instead of combining the CSS files during make, just install all of the
fragments and let mobile-config-autoconfig.js combine them.

As the API isn't well documented, add this helper function to log object
properties.

As the restart doesn't happen instantly, don't set the default
preferences in the restart code path. Split both code paths into
functions while at it.

It's pretty hard to get the code right in this autoconfig script, as the
only feedback you get is whether the script crashed or not. Add a
logging function to make it easier.

Indent these two lines, so it's visually clear that they are part of the
condition.