Skip to content
Snippets Groups Projects

mrhlpr: mr: use a simpler mechanism to detect if user approved a MR

Merged Clayton Craft requested to merge craftyguy/fix_approval_fetch into master
All threads resolved!

This doesn't depend on an auth error to detect if a user has approved a MR, and fixes #24 (closed).

For some reason mr.approval_state().get was 404'ing, causing #24 (closed).

Merge request reports

Pipeline #210713 passed with warnings

Pipeline passed with warnings for 297ff40a on craftyguy/fix_approval_fetch

Approved by

Merged by NewbyteNewbyte 4 months ago (Nov 21, 2024 8:27pm UTC)

Merge details

Pipeline #210714 passed with warnings

Pipeline passed with warnings for 297ff40a on master

Deployed to dep‎loy‎ 4 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Newbyte
  • Newbyte
  • Thanks for investigating this!

  • Clayton Craft added 1 commit

    added 1 commit

    • a8b57d2e - mrhlpr: mr: use a simpler mechanism to detect if user approved a MR

    Compare with previous version

  • Clayton Craft added 1 commit

    added 1 commit

    • 79be226d - mrhlpr: mr: use a simpler mechanism to detect if user approved a MR

    Compare with previous version

  • Anjan Momi approved this merge request

    approved this merge request

  • This fixed #24 (closed) for me

  • Anjan Momi resolved all threads

    resolved all threads

  • Newbyte resolved all threads

    resolved all threads

  • Newbyte approved this merge request

    approved this merge request

  • Newbyte added 4 commits

    added 4 commits

    • 79be226d...d49a1ccf - 3 commits from branch master
    • 297ff40a - mrhlpr: mr: use a simpler mechanism to detect if user approved a MR (MR 60)

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading