Phosh regression on slower devices due to removal of forked GTK 3.0 package

Following 59bc384b, we no longer apply "events-Compress-touch-update-events.patch" from https://source.puri.sm/Librem5/debs/gtk/-/blob/724e289ee0d8b9296722c256994825ae5f6235cc/debian/patches/pureos/events-Compress-touch-update-events.patch. This results in really bad hitching in GTK 3.0 apps on slower devices, especially the Phosh app drawer. I'm not sure what we can do about this. The patch is more of a hack than a proper solution, but it helps immensely with usability as without it you get a lot of stuttering and scrolling that reverses direction, even on devices like the Librem 5.

@pabloyoyoista, do you have any thoughts?

changed milestone to %v24.12 Release

added discussion release-edge ui-gnome ui-gnome-mobile ui-phosh labels

mentioned in issue #3087 (closed)

By Newbyte on 2024-08-10T19:56:01

marked #3087 (closed) as a duplicate of this issue

By Newbyte on 2024-08-10T19:56:06

marked this issue as related to #3087 (closed)

By Newbyte on 2024-08-10T19:56:07

I think this wouldn't only affect phosh (which could bundle it) but also the whole xfce and GTK3 apps like gedit and many others.

By Guido Günther on 2024-08-11T07:43:12

@pabloyoyoista, do you have any thoughts?

The options I see are:

• Bring back the fork, but with this single patch, which might make it more maintainable?
• Try to squeeze the patch in aports
• Bundle it with Phosh, and live with the fact that if somebody is annoyed with slow GTK3 apps, then please use GTK4 ones, or contribute to porting them. We've already walked this direction by removing the adaptive patchset

I certainly prefer the 3rd option Any thoughts?

By Pablo Correa Gomez on 2024-08-14T08:32:47

Bundle it with Phosh, and live with the fact that if somebody is annoyed with slow GTK3 apps, then please use GTK4 ones, or contribute to porting them. We've already walked this direction by removing the adaptive patchset

How would this even work? It's a patch for GTK 3.0, not Phosh. Do you mean that we'd bundle an entire separate build of the GTK 3.0 library in the Phosh package?

By Newbyte on 2024-08-14T08:32:47

Per @agx1 comment, I assumed there was a way to do so?

By Pablo Correa Gomez on 2024-08-19T11:48:28

If not, a fork with a single patch would be acceptable for me

By Pablo Correa Gomez on 2024-08-19T11:48:58

Another thing thing that went likely missing is due to dropping the fork is https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5628

By Guido Günther on 2024-08-30T09:38:20

No, this we did consider: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/69635

By Newbyte on 2024-08-30T09:38:20

Great! Sorry for the noise.

By Guido Günther on 2024-08-30T09:55:32

Just opened https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/72895

By Pablo Correa Gomez on 2024-10-02T10:55:21

https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/72895 was merged, so I'll close this. Thanks for taking care of it, Pablo!

By Newbyte on 2024-10-02T19:32:24

closed