main/postmarketos-base: modify tm2-touchkey udev rule for midas

PMA!2926 introduced touchkey functionality for midas devices (Exynos 4412 based Samsung Galaxy S III and Note II devices), however, due to hardware variants in the touchkeys, the keys are reversed. This amends the udev rules to ensure the non-midas devices have their configuration and the midas devices have theirs use the default configuration.

See my comments on closed issue PMA#1422.

added 1 commit

• 8df1a22a - main/postmarketos-base: modify tm2-touchkey udev rule for midas

Compare with previous version

By Jack K on 2022-06-05T18:35:55

marked this merge request as ready

By Jack K on 2022-06-05T19:12:53

CC @Newbyte and @Jakko

By Jack K on 2022-06-05T19:13:10

approved this merge request

By Alexey Min on 2022-06-05T20:14:21

I think the mapping is device-specific, not driver-specific (or hardware-specific, respectively). It depends on what icons the manufacturer printed on the devices' touch glass.

I don't know on what base manufacturers decided what icons to print into which corner (e.g. whether this is dependent on the Android version, age of phone, manufacturer-specific, etc.). Also I don't have an overview on what phones use tm2-touchkey variants and how their icons are ordered.

Roughly I would say that the arrangement that fits the majority should be placed into postmarketos-base. Arrangements that are rather rare would then need to be placed in the device package, overriding the main udev rule by increasing the file name number to 21-tm2-touchkey-input.rules. Well, so far, this is just an idea or suggestion.

The difficult thing is how to find out which arrangement is majority and which is minority. Currently I don't have a better idea than doing it iteratively: Let's start with what we have and then we need to improve over time, based on reports like yours.

Therefore I don't have any objection to this MR. In the logic described above, it sets the "majority" for sub-type "midas-touchkey" to "left: back" and "right: menu", whereas the "majority" of the other tm2-touchkey sub-types remain being set to "left: menu" and "right: back". If in future it turns out that several devices deviate from that, we might need to change something.

A small suggestion on the MR for better readability: I would change the last line to the order ENV{KEYBOARD_KEY_00}="back", ENV{KEYBOARD_KEY_01}="menu", RUN{builtin}+="keyboard" and accordingly the comment to # map tm2-touchkey to KEY_BACK and KEY_MENU (midas variant)

By Jakko on 2022-06-06T00:14:21

added 18 commits

• 8df1a22a...1f3c16ca - 17 commits from branch postmarketOS:master
• 6f02e181 - main/postmarketos-base: modify tm2-touchkey udev rule for midas

Compare with previous version

By Jack K on 2022-06-06T21:52:23

changed the description

By Jack K on 2022-06-06T21:56:06

added 9 commits

• 6f02e181...dcfaa6ac - 8 commits from branch postmarketOS:master
• ec8ef733 - main/postmarketos-base: modify tm2-touchkey udev rule for midas

Compare with previous version

By Jack K on 2022-06-07T21:27:11

approved this merge request

By Minecrell on 2022-06-08T19:19:43

resolved all threads

By Jack K on 2022-06-08T19:38:50

added 3 commits

• ec8ef733...1770b37b - 2 commits from branch postmarketOS:master
• f86bd5e9 - main/postmarketos-base: modify tm2-touchkey udev rule for midas

Compare with previous version

By Jack K on 2022-06-08T19:40:17

approved this merge request

By Oliver Smith on 2022-06-09T06:07:52

added 1 commit

• 4912e44a - main/postmarketos-base: modify tm2-touchkey udev rule for midas (MR 3192)

Compare with previous version

By Oliver Smith on 2022-06-09T06:09:16

enabled an automatic merge when the pipeline for 4912e44a succeeds

By Oliver Smith on 2022-06-09T06:09:27

merged