main/postmarketos-base: enable zram-init service on upgrade

The post-upgrade script in pmos-base isn't symlinked to the post-install script, so zram-init wasn't being enabled on systems that upgraded to the pmos-base version that intro'd this feature. I think this should have been enabled by default on upgraded systems. There's a deviceinfo toggle for it, so users who won't want to use this can set that var to disable it, in that case having the service enabled is basically a no-op.

(cc @pabloyoyoista)

added backport-to-v23.12 label

approved this merge request

By Pablo Correa Gomez on 2023-12-05T17:45:34

added category::infrastructure type::fix labels

mentioned in merge request !4588 (closed)

By clayton craft on 2023-12-05T23:50:44

Sorry that I'm seeing the MR only now (feel free to ping me about "time critial" MRs next time). Looks fine to me to merge it to edge, but given that it is opt-out I feel it's a bit too risky for v23.12 at this point given that we are close to the end of the testing phase and previous tests have been done without this.

So I'll not merge it to v23.12 right now, only to edge. I'll mention in the blog post though that users can turn on the zram-init service manually if they want to.

Does that sound reasonable? Feel free to ping me about it (in matrix) if you want to discuss it further shortly.

With all that being said, this is a cool feature and I'd enable it in the first service pack if we notice no regression in edge until then.

By Oliver Smith on 2023-12-07T19:31:26

removed backport-to-v23.12 label

approved this merge request

By Oliver Smith on 2023-12-07T19:32:11

added 8 commits

• ea3963bf...f6467c52 - 7 commits from branch master
• ead7133c - main/postmarketos-base: enable zram-init service on upgrade (MR 4598)

Compare with previous version

By Oliver Smith on 2023-12-07T19:32:18

actually I'll also add a comment in the post-install that users can disable this via deviceinfo if they wish. otherwise it will not be obvious and seem like it would just always auto turn-on after upgrade.

By Oliver Smith on 2023-12-07T19:33:06

added 1 commit

• dbd23fb1 - main/postmarketos-base: enable zram-init service on upgrade (MR 4598)

Compare with previous version

By Oliver Smith on 2023-12-07T19:38:25

mentioned in issue postmarketos.org#155 (closed)

By Oliver Smith on 2023-12-07T19:39:45

merged

mentioned in issue #2428 (closed)

By Oliver Smith on 2023-12-07T19:42:29