modem/ofono: update to 1.29 with qmi voicecall support
The Donesupport-smdpkt.patch patch doesn't apply anymore and I believe some devices still need that patch.
Tested on the pinephone devkit.
Closes #231 (closed)
Merge request reports
Activity
added category::upgrade label
mentioned in issue #231 (closed)
By Luca Weiss on 2019-07-19T19:54:55
Some remarks for the smdpkt patch:
There's a slightly different version of the patch on the ofono mailing list https://www.mail-archive.com/ofono@ofono.org/msg17642.html , especially the second patch in that series has more stuff to it, but apparently it isn't very needed (or is it?)...
By Luca Weiss on 2019-07-19T20:15:08
-
I am wondering if it makes sense to keep an ofono fork in postmarketOS around at this point at all. The reason for doing it in the first place was, that Alpine's ofono was outdated, and we wanted to use patches that allow QMI voice calls.
Nowadays, Alpine's version is up to date (1.29), and it seems that we can get patches to update Alpine packages merged in reasonable time now.
I don't find the QMI related patches so useful at the moment, because we can't use the modem at all right now on hammerhead or other devices. So we might as well not go through the efforts of keeping a fork with these patches around, until that is working again. (And afterwards, rather work together with upstream to get the patches integrated into upstream ofono.)
@z3ntu, what do you think, should we just drop our fork for now?
In any case, thank you very much for your work on this
By Oliver Smith on 2019-07-20T20:41:45
Edited by Administrator -
I am wondering if it makes sense to keep an ofono fork in postmarketOS around at this point at all. The reason for doing it in the first place was, that Alpine's ofono was outdated, and we wanted to use patches that allow QMI voice calls.
FYI I am in the process of writing the libsamsung-ipc drivers for ofono (based on the 8 year old patches that were never accepted, my tree is at https://github.com/xc-racer99/ofono/). They are not complete yet, but I can boot the modem and register on the network on pmOS on a mainline based kernel on my device (SGH-T959P, a first-gen Galaxy S device. pmOS support isn't upstream as I'm still working through some bugs locally on the mainline kernel, mostly related to audio and 3D acceleration with a PowerVR SGX540...)
Whether this impacts the decision to keep the forked ofono around or not is up to you :) I could always re-fork it when my patches reach a more stable state.
By Jonathan Bakker on 2019-07-20T21:45:47
-
Hey @xc-racer99, these are awesome news!
Whether this impacts the decision to keep the forked ofono around or not is up to you :) I could always re-fork it when my patches reach a more stable state.
Exactly. And of course the best outcome would be having your patches upstreamed to mainline ofono.
By Oliver Smith on 2019-07-21T01:10:26
mentioned in commit c1e94f7c
By Oliver Smith on 2019-07-23T21:55:47
added 5 commits
-
2a526f68...7d8ef5a2 - 4 commits from branch
master - c1e94f7c - modem/ofono: update to 1.29 with qmi voicecall support (!511 (merged))
By Oliver Smith on 2019-07-23T21:55:47
-
2a526f68...7d8ef5a2 - 4 commits from branch
mentioned in commit 73f6cfa0
By Luca Weiss on 2019-07-23T22:02:47
added 1 commit
- 73f6cfa0 - modem/ofono: update to 1.29 with qmi voicecall support (!511 (merged))
By Oliver Smith on 2019-07-23T22:02:48
-
I see. Let's merge this for now, this is definitively an improvement. Thanks again!
However, I think we should move this to temp and set the pkgver to 9999. Otherwise it will get replaced with Alpine's version as soon as Alpine has a newer version.
@z3ntu, do you want to create a follow-up MR?
By Oliver Smith on 2019-07-23T22:03:09