kconfigcheck: Fix ZRAM checks
main/postmarketos-base/rootfs-etc-conf.d-zram-init configures zstd as our default ZRAM configuration, but the kconfigcheck only checks for LZ4 at the moment. Because of this some of our kernels don't actually have ZSTD support enabled and end up using the default compression algorithm.
- For Linux >=4.18 we should enable CONFIG_CRYPTO_ZSTD to enable ZSTD support for ZRAM.
- In Linux >=6.12 the configuration was changed to CONFIG_ZRAM_BACKEND_ZSTD. This requires manual edits while upgrading, otherwise only LZO support will remain enabled.
- Checking for >=3.14.0 additionally does not make any sense, because the kconfig check should not be enabled for kernels that cannot satisfy our minimum requirements.
Describe this properly in kconfigcheck.toml to ensure kernels are configured correctly.
The following kernels are currently missing the correct options:
config-htc-flounder.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-amlogic.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-grate.armv7: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-qcom-msm8974.armv7: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-qcom-sc7280.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-qcom-sm6115.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-postmarketos-qcom-sm6350.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-purism-librem5.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
The following kernels are too old to support CONFIG_CRYPTO_ZSTD:
config-samsung-jxelte.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
config-volla-mimameid.aarch64: CONFIG_CRYPTO_ZSTD should be set (category:zram)
IMO we should drop pmb:kconfigcheck-zram
for these since this is a configuration that we can't actively test or support.
Merge request reports
Activity
- Resolved by Robert Eckelmann
TODO: This MR is missing the kernel config fixes for the kernels mentioned above. I assume CI wouldn't complete them in time and I don't have access to a good build machine right now to test building them all locally. Help with this would be much appreciated, feel free to just push to this MR. :)
mentioned in merge request !5821 (merged)
mentioned in merge request !5830 (merged)
mentioned in merge request !5837 (merged)
added 17 commits
-
d0c33e25...207873d6 - 13 commits from branch
postmarketOS:master
- ae4a66f3 - kconfigcheck: Fix ZRAM checks (MR 5835)
- b1045203 - linux-samsung-jxelte: drop ZRAM kconfigcheck (MR 5835)
- f8868bee - linux-volla-mimameid: drop ZRAM kconfigcheck (MR 5835)
- 95d3b46f - linux-postmarketos-grate: add CONFIG_CRYPTO_ZSTD (MR 5835)
Toggle commit list-
d0c33e25...207873d6 - 13 commits from branch
added 9 commits
- 8ae12a9d - kconfigcheck: Fix ZRAM checks (MR 5835)
- 2556ec2b - linux-samsung-jxelte: drop ZRAM kconfigcheck (MR 5835)
- e663d7d1 - linux-volla-mimameid: drop ZRAM kconfigcheck (MR 5835)
- 27fcdc06 - linux-postmarketos-grate: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 3a08f9c7 - linux-htc-flounder: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 951ae285 - linux-postmarketos-amlogic: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 8354e371 - linux-psotmarketos-qcom{msm8974,msm8994,sc7280,sm6115,sm6350}: add (MR 5835)
- d297609e - linux-purism-librem5: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 00825718 - bump these pkg_rels (to be squished later) (MR 5835)
Toggle commit listadded 1 commit
- 5952a3c3 - bump these pkg_rels (to be squished later) (MR 5835)
added 1 commit
- e4092074 - bump these pkg_rels (to be squished later) (MR 5835)
- Resolved by Minecrell
Should we also require ZRAM_DEF_COMP_ZSTD for >=6.12? The "Default zram compressor" would otherwise default to lzo-rle and not zstd, but maybe it doesn't matter if we're setting it from user space anywys?
mentioned in merge request !5847 (merged)
added 9 commits
-
627e427c - 1 commit from branch
postmarketOS:master
- f29b60f5 - kconfigcheck: Fix ZRAM checks (MR 5835)
- d377a08c - linux-samsung-jxelte: drop ZRAM kconfigcheck (MR 5835)
- 1de20d1c - linux-volla-mimameid: drop ZRAM kconfigcheck (MR 5835)
- c07b55e8 - linux-postmarketos-grate: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 133514ea - linux-htc-flounder: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 6e2a1278 - linux-postmarketos-amlogic: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 8cf0811f - linux-psotmarketos-qcom{msm8974,msm8994,sc7280,sm6115,sm6350}: add (MR 5835)
- 5b1bd408 - linux-purism-librem5: add CONFIG_CRYPTO_ZSTD (MR 5835)
Toggle commit list-
627e427c - 1 commit from branch
added 9 commits
-
34ad0ba5 - 1 commit from branch
postmarketOS:master
- 89b63230 - kconfigcheck: Fix ZRAM checks (MR 5835)
- 238f06de - linux-samsung-jxelte: drop ZRAM kconfigcheck (MR 5835)
- 8db10926 - linux-volla-mimameid: drop ZRAM kconfigcheck (MR 5835)
- 5110db89 - linux-postmarketos-grate: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 8a61702f - linux-htc-flounder: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 85aea8b1 - linux-postmarketos-amlogic: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 5bf18067 - linux-postmarketos-qcom{msm8974,msm8994,sc7280,sm6115,sm6350}: add...
- 759dcd30 - linux-purism-librem5: add CONFIG_CRYPTO_ZSTD (MR 5835)
Toggle commit list-
34ad0ba5 - 1 commit from branch
added 8 commits
- 3acdb581 - kconfigcheck: Fix ZRAM checks (MR 5835)
- 8969b015 - linux-samsung-jxelte: drop ZRAM kconfigcheck (MR 5835)
- 9c55a407 - linux-volla-mimameid: drop ZRAM kconfigcheck (MR 5835)
- 1cb8193d - linux-postmarketos-grate: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 13947dff - linux-htc-flounder: add CONFIG_CRYPTO_ZSTD (MR 5835)
- f2f1c4f1 - linux-postmarketos-amlogic: add CONFIG_CRYPTO_ZSTD (MR 5835)
- 1c17f832 - linux-postmarketos-qcom{msm8974,msm8994,sc7280,sm6115,sm6350}: add...
- 29e1a5f6 - linux-purism-librem5: add CONFIG_CRYPTO_ZSTD (MR 5835)
Toggle commit list