Skip to content
Snippets Groups Projects
Unverified Commit 22865fdf authored by Oliver Smith's avatar Oliver Smith
Browse files

build: package: rename do_continue -> missing_deps (MR 2388)

Make the code easier to understand with a more meaningful variable name.
parent 9542ed00
Branches
Tags
1 merge request!2388Properly build outdated dependencies for packages
......@@ -255,11 +255,11 @@ def prioritise_build_queue(disarray: list[BuildQueueItem]) -> list[BuildQueueIte
break
# If a dependency hasn't been queued yet, skip until it has been
do_continue = False
missing_deps = False
for dep in item["depends"]:
if dep in all_pkgnames:
unmet_deps.setdefault(item["name"], []).append(dep)
do_continue = True
missing_deps = True
if any(
x in unmet_deps.get(dep, [])
for x in [item["name"]] + list(item["apkbuild"]["subpackages"].keys())
......@@ -279,7 +279,7 @@ def prioritise_build_queue(disarray: list[BuildQueueItem]) -> list[BuildQueueIte
"WARNING: cyclical build dependency: can't build {item['name']}, no binary package for {dep}"
)
if do_continue:
if missing_deps:
continue
# We're probably good to go??
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment