Skip to content
Snippets Groups Projects

build: package: skip prioritizing deps of pkg which are a subpkg of pkg

Merged Caleb Connolly requested to merge caleb/build-resolve-dep-is-subpkg into master
All threads resolved!

Some packages in aports have their own subpackages in their dependencies, for some reason. This causes our resolver to assume there is a cyclical dependency.

Adjust the resolver to safely ignore these dependencies, since they'll be built as a part of the package that depends on them.

For example, modemmanager depends on libmm-glib which is a subpackage of modemmanager. Currently to build modemmanager in pmaports it would be necessary to manually modify the APKBUILD after copying it from aports. This change avoids that.

Fix #2473 (comment 453424)

Edited by Oliver Smith

Merge request reports

Merge request pipeline #209058 passed

Merge request pipeline passed for 50321d41

Merged by Oliver SmithOliver Smith 4 months ago (Oct 27, 2024 6:40pm UTC)

Loading

Pipeline #209059 passed

Pipeline passed for 50321d41 on master

Deployed to dep‎loy‎ 4 months ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • mentioned in issue #2473 (closed)

  • added 1 commit

    • c963ddac - build: package: skip prioritizing deps of pkg which are a subpkg of pkg

    Compare with previous version

  • Oliver Smith mentioned in merge request !2457 (merged)

    mentioned in merge request !2457 (merged)

  • Oliver Smith added 14 commits

    added 14 commits

    • c963ddac...2106e13f - 13 commits from branch master
    • 4bdf9348 - build: package: skip prioritizing deps of pkg which are a subpkg of pkg (MR 2459)

    Compare with previous version

  • Oliver Smith resolved all threads

    resolved all threads

  • Oliver Smith approved this merge request

    approved this merge request

  • Oliver Smith changed the description

    changed the description

  • Oliver Smith changed the description

    changed the description

  • Caleb Connolly resolved all threads

    resolved all threads

  • Caleb Connolly added 6 commits

    added 6 commits

    • 4bdf9348...acc989de - 5 commits from branch master
    • e6f6edb5 - build: package: skip prioritizing deps of pkg which are a subpkg of pkg

    Compare with previous version

  • added 1 commit

    • 7923c3e4 - build: package: skip prioritizing deps of pkg which are a subpkg of pkg (MR 2459)

    Compare with previous version

  • Caleb Connolly enabled an automatic merge when all merge checks for 7923c3e4 pass

    enabled an automatic merge when all merge checks for 7923c3e4 pass

  • Oliver Smith aborted the automatic merge because the source branch was updated. Learn more.

    aborted the automatic merge because the source branch was updated. Learn more.

  • Oliver Smith added 2 commits

    added 2 commits

    • 497188eb - CI: force IPv4 for gitlab.postmarketos.org (MR 2459)
    • 50321d41 - build: package: skip prioritizing deps of pkg which are a subpkg of pkg (MR 2459)

    Compare with previous version

  • Oliver Smith enabled an automatic merge when all merge checks for 50321d41 pass

    enabled an automatic merge when all merge checks for 50321d41 pass

  • merged

  • Please register or sign in to reply
    Loading