require_programs: Debian: find kpartx and losetup

In Debian, /usr/sbin is not in PATH of regular users unless using sudo. Fix that pmbootstrap won't find kpartx and losetup in /usr/sbin, and complains about these even though they are installed.

Fix #2489 (closed)

Fix #2482 (closed)

Fix #2492 (closed)

changed the description

changed milestone to %3.0.0 critical path (blockers only!!)

approved this merge request

mentioned in issue #2489 (closed)

Also fixes #2482 (closed)

changed the description

I had a try. On pmboostrap init there is an error. With option --details-to-stdout I can see:

% losetup --json
ERROR: [Errno 2] No such file or directory: 'losetup'

It's comming from the part where losetup is called with option --json as a check:

    if "losetup" not in missing:
        # Check if losetup supports the --json argument.
        try:
            pmb.helpers.run.user(["losetup", "--json"], check=True)
        except RuntimeError:
            losetup_missing_json = True

https://gitlab.postmarketos.org/postmarketOS/pmbootstrap/-/blob/3b4b9cd061343245a2a2dfea4a16dbf2cbe96d21/pmb/config/init.py#L45-50

In Debian it would need to be /usr/sbin/losetup with option --json, unfortunately.

approved this merge request

approved this merge request

resolved all threads

added 2 commits

• c3337c3e - config: find required programs every time pmbootstrap is run
• d4201c7f - chroot: merge executibles_absolute_path() logic into require_programs()

Compare with previous version

added 6 commits

• d4201c7f...3b4b9cd0 - 3 commits from branch postmarketOS:master
• 460df0d4 - require_programs: Debian: find kpartx and losetup
• f6070a51 - config: find required programs every time pmbootstrap is run
• e173dc1a - chroot: merge executibles_absolute_path() logic into require_programs()

Compare with previous version

assigned to @ollieparanoid

added 11 commits

• e173dc1a...ef9d6181 - 6 commits from branch postmarketOS:master
• c4194759 - require_programs: Debian: find kpartx and losetup (MR 2475)
• 585c4772 - config: find required programs every time pmbootstrap is run (MR 2475)
• 765ba770 - chroot: merge executibles_absolute_path() logic into require_programs() (MR 2475)
• 54e55f26 - require_programs: run losetup with absolute path (MR 2475)
• ee154ccd - require_programs: losetup --json: set output=null (MR 2475)

Compare with previous version

resolved all threads

I've addressed the review comments. Merging this now as it fixes an important bug that many people run into. Thanks for all the reviews and testing!

enabled an automatic merge when all merge checks for ee154ccd pass