require_programs: Debian: find kpartx and losetup (!2475) · Merge requests · postmarketOS / pmbootstrap · GitLab

Snippets Groups Projects

Merged Oliver Smith requested to merge ollieparanoid/pmbootstrap:fix-debian-init into master 5 months ago

Nov 06, 2024

require_programs: losetup --json: set output=null (MR 2475) · ee154ccd

Oliver Smith authored 4 months ago

We don't care about the output of "losetup --json" here, we just want to
make sure that the argument exists. If it does not exist, we already
give an error to the user.

Set the output to null so it does not clutter the log since it runs with
every pmbootstrap command now.

ee154ccd

require_programs: run losetup with absolute path (MR 2475) · 54e55f26

Oliver Smith authored 4 months ago

Use the absolute path for it, so it works in Debian too as we run it
without sudo here to just check if the argument is supported.

54e55f26

chroot: merge executibles_absolute_path() logic into require_programs() (MR 2475) · 765ba770

Caleb Connolly authored 5 months ago and

Oliver Smith committed 4 months ago


Remove this chroot-specific helper and merge it in with the existing
require_programs() logic. Now we have one unified way to discover and
use programs from the host and where we can put any additional special
handling we might need.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

765ba770

config: find required programs every time pmbootstrap is run (MR 2475) · 585c4772

Caleb Connolly authored 5 months ago and

Oliver Smith committed 4 months ago


On debian systems in particular special handling is needed for
/usr/sbin. Let's do this once and then provide the host deps we use in a
nice accessible dictionary.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>
Tweaked-by: Oliver Smith <ollieparanoid@postmarketos.org>

585c4772

require_programs: Debian: find kpartx and losetup (MR 2475) · c4194759

Oliver Smith authored 5 months ago

In Debian, /usr/sbin is not in PATH of regular users unless using sudo.
Fix that pmbootstrap won't find kpartx and losetup in /usr/sbin, and
complains about these even though they are installed.

Fixes: issue 2489

c4194759