samsung-kylessopen: Modernized APKBUILD
I've modified the APKBUILD for this device to clean it up a bit and to point it to my kernel repo as well. This'll make it far easier to test out various vendor kernels and should make mainlining a bit easier.
Merge request reports
Activity
added 1 commit
- ec64671b - samsung-kylessopen: Added commit variable
By Ghost User on 2019-05-05T07:48:15
added 1 commit
- e3a96af3 - samsung-kylessopen: Fixed embarassing mistake
By Ghost User on 2019-05-05T08:05:28
-
It's because of !345 (comment 166835515) but you can also clear your cache with
pmbootstrap zap -dBy Luca Weiss on 2019-05-05T08:31:04
added 5 commits
-
230433ad - 1 commit from branch
postmarketOS:master - d604f11b - samsung-kylessopen: Modernized APKBUILD
- d68575d0 - samsung-kylessopen: Added commit variable
- 990053b8 - samsung-kylessopen: Fixed embarassing mistake
- 52d3bb48 - samsung-kylessopen: Minor issue
By Ghost User on 2019-05-05T10:30:39
Toggle commit list-
230433ad - 1 commit from branch
added 5 commits
-
271aba5d - 1 commit from branch
postmarketOS:master - acc4a4fc - samsung-kylessopen: Modernized APKBUILD
- 1fd7eeeb - samsung-kylessopen: Added commit variable
- 37fe2d91 - samsung-kylessopen: Fixed embarassing mistake
- c9f0c40e - samsung-kylessopen: Minor issue
By Ghost User on 2019-05-05T21:13:58
Toggle commit list-
271aba5d - 1 commit from branch
-
We can continue to add patches to the aport dir. The issue is, a lot of the people who maintain kernel repos for this device are starting to delete them. I'd just like the APKBUILD to point to a kernel that I know will be there sometime in the future. I also just happen to prefer messing with kernels via changing the APKBUILD, because it feels more flexible. If you look at the source that the kernel is in, you'll see that I've forked 14 different kernels for this device. It's a lot easier for me if I just change a couple small strings in a file I prefer editing and saving the file for later personal use rather than downloading the source manually, manually patching and hoping for the best.
I'll fix the commit message issue in a sec. I'm trying to see if I can get the kernel to compile with GGC8 again and I seem to be making progress.
By Ghost User on 2019-05-06T23:45:57
added 11 commits
-
6077e3c1...5cf1ee92 - 4 commits from branch
postmarketOS:master - 04ac189d - samsung-kylessopen: Modernized APKBUILD
- 5f84a63c - samsung-kylessopen: Added commit variable
- 7f3fabd0 - samsung-kylessopen: Fixed embarassing mistake
- 884912f4 - samsung-kylessopen: Minor issue
- a54de54b - samsung-kylessopen: Fixed embarassing mistake
- 70218af6 - samsung-kylessopen: Minor issue
- 9cd37cc3 - Compiles with GCC8
By Ghost User on 2019-05-07T01:02:47
Toggle commit list-
6077e3c1...5cf1ee92 - 4 commits from branch
-
The issue is, a lot of the people who maintain kernel repos for this device are starting to delete them. I'd just like the APKBUILD to point to a kernel that I know will be there sometime in the future
We have https://github.com/pmsourcedump for that.
I'm sure everybody has their reasons to prefer a kernel repo, but I agree with @ollieparanoid that having patches separately in the package makes it more transparent what the differences are. Besides, we should act the same for every package, and not differ from methods for a single person.
Having a reliable git repo as source is a good argument, but because development is easier isn't in this case in my opinion.
By Bart Ribbers on 2019-05-07T13:55:27
-
pmsourcedump isn't exactly useful if the maintainer deletes the repo before you clone it. That's why I've forked all the unique ones I could find.
I think all three of us agree upon having patches separately in the device package. I'm not asking that we treat this phone any differently than the others.
All I'm suggesting is that we're better off changing the repo to one that we all know will be there in the future. We don't know if or when the github repo will become unavailable and if it does, we'll have to change the repo anyways. I just feel like it's better to change the repo now so that we wont have to in the future. I've put a lot of work into this specific device.
Anyhow, I'll let @ollieparanoid be the tiebreaker here. If you still believe that using the old github repo is what's best for this device, I'll make the changes. I just ask that you try to see this from my perspective.
By Ghost User on 2019-05-07T16:34:06