Alexandre Messier authored 4 months ago and Oliver Smith committed 4 months ago

When lk2nd is a dependency of a device subpackage (e.g. a mainline
kernel subpackage), it is not detected.

If no lk2nd pacakge is found, also parse the dependencies of all
subpackages.

Signed-off-by: Alexandre Messier <alex@me.ssier.org>

Otherwise mypy thinks it differs slightly from the <fork_alpine> == True
vs the <fork_alpine> == False code path.

Otherwise this will crash as you cannot directly concatenate str with
Arch, but f-strings don't have this problem.

This argument doesn't exist. Presumably this was copied from
filter_arch_packages() without adapting the comment.

This is the only command to return a bool from run rather than None, and
this return type doesn't seem to get used anywhere, so let's just remove
it.

Otherwise mypy gets confused about the type as in this case the variable
gets set to a boolean and not a string.

See code comment for explanation.

pmb.helpers.cli.ask() returns a string, so previously this function was
just lying about its return type (which happened to be fine in the
context it was used, but still not what we want).

pmb.helpers.cli.ask() takes a string and only work with Path by
accident, so explicitly convert <default> to a string if it is not None.

Additionally, while this function claimed to return a Path, it actually
returned a string, so fix that too.

Otherwise mypy gets confused by the type later in the code, and I also
think it might be confusing behaviour in general that <options> gets
overwritten in this loop.

The mentioned variable no longer exists, so update it to reflect how
things work now.

The parameters of this function were needlessly complicated. While I
understand the intent of trying to replicate the API of retrieve()
without duplicating the parameter list, in practice this feels like
reducing duplication to a fault to me. This is due to that the third
parameter, <allow_404>, doesn't make sense in the context of
retrieve_json() as it would raise an exception[1] if retrieve() returns
None (which is the effect of <allow_404> when a 404 occurs), thus merely
changing the exception that gets raised to a less descriptive one
instead of actually behaving like retrieve() would with that parameter
set to True.

With <allow_404> eliminated, there's just two parameters left, and I
don't think duplicating those is a big deal. So make the function easier
to read and annotate by getting rid of the args/kwargs logic.

 [1]: json.loads() raises an exception if its first argument is None

Minecrell authored 4 months ago and Minecrell committed 4 months ago

Devices using fastboot-bootpart typically boot directly from the boot file
system. They might still support "fastboot boot" though, which can be used
to boot a modified kernel more easily. Enable this similar to the existing
"flash_boot" action.

Make codespell CI check pass again. This is trivial, so directly pushing
to master.

Prepare a new release, so pmbotostrap can be used with Alpine 3.21 /
postmarketOS v24.12. Also the big rewrite is done, so we can do more
frequent releases again.

Related: https://wiki.postmarketos.org/wiki/Pmbootstrap_release

Anri Dellal authored 4 months ago and Oliver Smith committed 4 months ago

The note suggests to make local changes to git configuration
instead of expanding .gitingore with more editor files

Anri Dellal authored 4 months ago and Oliver Smith committed 4 months ago

Fix #2516

Anri Dellal authored 4 months ago and Newbyte committed 4 months ago

Moves locale setup code to separate function
Adds code to install keyboard configuration based on chosen locale

Anri Dellal authored 4 months ago and Newbyte committed 4 months ago

Add module that provides utilities and information related to localization.

Initial implementation includes code to generate keyboard configs
for locale set by user.

Oliver Smith authored 4 months ago and Newbyte committed 4 months ago

Move the description of PMB_SUDO from the README to docs.

Oliver Smith authored 4 months ago and Newbyte committed 4 months ago

Fix the following:

  WARNING: Failed to import pmb.commands.kconfig_check.
  WARNING: Failed to import pmb.commands.kconfig_edit.
  WARNING: Failed to import pmb.core.crosstool.

Crosstool has been dropped and kconfig_check/_edit code has been merged
into a kconfig module.

Do not abort if one or more APKINDEX files cannot be downloaded, if
PMB_APK_FORCE_MISSING_REPOSITORIES is set. This is needed when
bootstrapping new stable branches. The same environment variable is
already used in pmbootstrap code to pass --force-missing-repositories to
apk in pmb.chroot.apk.install_run_apk().

Casey authored 4 months ago and Oliver Smith committed 4 months ago

the kernel has pending patches in -next which adjust the generated
Makefile in the output directory to include the source tree makefile
with an absolute path, this breaks envkernel which relies on it being a
relative path.

Fix this by mounting our own Makefile instead using the relative path.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

Casey authored 4 months ago and Oliver Smith committed 4 months ago

We used to use .output as the default kbuild_out but this was removed
recently, add it back!

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

This commit removes separator in split function arguments, so arrays
where items are separates by tabulation don't fail to parse properly.

Casey authored 5 months ago and Oliver Smith committed 4 months ago

Pmbootstrap finds all its host dependencies during init, ensure we do
that for pytest too.

Adapt require_programs() to use subprocess directly rather than have to
solve the weird dependency chain of pmb.helpers.run which depends on the
global context being initialised before it's usable.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

Casey authored 5 months ago and Oliver Smith committed 4 months ago

Add some tests to ensure that we spit out correct deviceinfo options for
boot images of header v0, 2, and 3.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

Casey authored 5 months ago and Oliver Smith committed 4 months ago

Add some unit tests to ensure that the parser correctly detects boot
images with header v0, 2, and 3.

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

Casey authored 5 months ago and Oliver Smith committed 4 months ago

make sure that calls to get_upstream_remote() will succeed by setting
pmb.config.git_repos() for the entire run. This might pollute some other
tests...

TODO: make less things depend on pmaports being cloned...

Signed-off-by: Caleb Connolly <caleb@postmarketos.org>

Casey authored 5 months ago and Oliver Smith committed 4 months ago

This test includes a binary blob which we want to avoid in our codebase.

It is also better suited as a unit test where it can contribute to code
coverage. Revert this and use a unit test version instead.

This reverts commit d19de946.

Closes #2501

I think this is easier to read and has more obvious error handling.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>

pmbootstrap qemu did not respect architecture-specfic QEMU command name
mappings.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>