Skip to content
Snippets Groups Projects

samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

Merged Imported samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base
tm-touchkey into master
All threads resolved!
Merged Imported Administrator requested to merge tm-touchkey into master
All threads resolved!

Fixes #1422 (closed)

Edited by Administrator

Merge request reports

Approved by
Administrator

Merged by AdministratorAdministrator 3 years ago (Mar 3, 2022 4:40pm UTC)

Merge details

Pipeline #200855 passed

Stage: lint
Stage: build

Pipeline passed for 9833cc8a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Administrator added 1 commit · Imported

    added 1 commit

    • a69eb51b - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-12T07:27:50

  • Administrator added 1 commit · Imported

    added 1 commit

    • 56c77c7a - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-12T07:29:00

  • Administrator resolved all threads · Imported

    resolved all threads

    By Raymond Hackley on 2022-02-12T07:29:59

  • Administrator resolved all threads · Imported

    resolved all threads

    By Newbyte on 2022-02-12T08:53:25

  • Administrator resolved all threads · Imported

    resolved all threads

    By Jakko on 2022-02-12T11:18:48

  • Administrator resolved all threads · Imported

    resolved all threads

    By Newbyte on 2022-02-12T11:23:06

    • Administrator
      Administrator @root · Imported
      Author Owner
      Resolved by Administrator

      This udev rule now applies to all devices that use the tm2-touchkey driver. There might be devices we're not aware of. We don't know how their right key is mapped and if that makes sense in combination with their left key being mapped to "menu".

      Therefore the right key should be mapped as well. This provides the same set of key mapping to all devices using tm2-touchkey in postmarketOS [edit: when using a kernel ≥ 5.16].

      # map tm2-touchkey to KEY_MENU and KEY_BACK
SUBSYSTEM=="input", KERNEL=="event*", DRIVERS=="tm2-touchkey", ENV{KEYBOARD_KEY_00}="menu", ENV{KEYBOARD_KEY_01}="back", RUN{builtin}+="keyboard"

      Maybe split to two lines:

      # map tm2-touchkey to KEY_MENU and KEY_BACK
SUBSYSTEM=="input", KERNEL=="event*", DRIVERS=="tm2-touchkey", \
ENV{KEYBOARD_KEY_00}="menu", ENV{KEYBOARD_KEY_01}="back", RUN{builtin}+="keyboard"

      By Jakko on 2022-02-13T03:11:24

      Edited by Administrator
  • Administrator added 1 commit · Imported

    added 1 commit

    • 32456e6f - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T03:10:40

  • Administrator approved this merge request · Imported

    approved this merge request

    By clayton craft on 2022-02-13T04:25:38

  • Administrator added 1 commit · Imported

    added 1 commit

    • 60987bb3 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T04:29:56

  • Administrator added 2 commits · Imported

    added 2 commits

    • b0971223 - 1 commit from branch postmarketOS:master
    • 88f6c79a - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T16:08:26

  • Administrator resolved all threads · Imported

    resolved all threads

    By Raymond Hackley on 2022-02-13T16:08:44

  • Administrator changed the description · Imported

    changed the description

    By Raymond Hackley on 2022-02-13T16:09:51

  • Administrator changed the description · Imported

    changed the description

    By Raymond Hackley on 2022-02-13T16:10:53

    • Administrator
      Administrator @root · Imported
      Author Owner
      Resolved by Administrator

      The first comment line... # remap the left key of tm2-touchkey to KEY_MENU ... is actually not needed anymore. My idea was to replace it by a more general description (now second comment line), too bad I failed on the code suggestion feature. Well, it's not that important.

      By Jakko on 2022-02-13T17:33:47

      Edited by Ghost User
  • Administrator added 1 commit · Imported

    added 1 commit

    • 623423f3 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T17:36:13

  • Administrator resolved all threads · Imported

    resolved all threads

    By Raymond Hackley on 2022-02-13T17:37:09

  • Administrator added 2 commits · Imported

    added 2 commits

    • b0971223 - 1 commit from branch postmarketOS:master
    • a6a74dc1 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T18:30:10

  • Administrator added 3 commits · Imported

    added 3 commits

    • a6a74dc1...408cfc08 - 2 commits from branch postmarketOS:master
    • 418f78a2 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-13T19:09:53

  • Administrator added 6 commits · Imported

    added 6 commits

    • 418f78a2...caec1456 - 5 commits from branch postmarketOS:master
    • 613eae78 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-16T21:00:22

  • Administrator added 1 commit · Imported

    added 1 commit

    • f1869484 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-16T21:01:48

  • Administrator added 2 commits · Imported

    added 2 commits

    • f5950094 - 1 commit from branch postmarketOS:master
    • b178b146 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-17T10:26:59

  • Administrator added 2 commits · Imported

    added 2 commits

    • 66608e54 - 1 commit from branch postmarketOS:master
    • 50555cea - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-17T20:34:17

  • Administrator added 2 commits · Imported

    added 2 commits

    • def72d94 - 1 commit from branch postmarketOS:master
    • 5f150e79 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-18T04:12:04

  • Administrator added 16 commits · Imported

    added 16 commits

    • 5f150e79...78ff5e89 - 15 commits from branch postmarketOS:master
    • 367af18d - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-22T06:51:23

  • Administrator added 11 commits · Imported

    added 11 commits

    • 367af18d...297ff6bf - 10 commits from branch postmarketOS:master
    • dc76aeef - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-02-28T17:51:46

  • Administrator added 7 commits · Imported

    added 7 commits

    • dc76aeef...6127af78 - 6 commits from branch postmarketOS:master
    • 737b320d - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-03-03T15:55:09

  • Administrator added 1 commit · Imported

    added 1 commit

    • d9622812 - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-03-03T16:09:45

  • Administrator added 1 commit · Imported

    added 1 commit

    • 737b320d - samsung-{a3,a5,a7,klte,serranove}: Move 20-tm2-touchkey-input.rules to postmarketos-base

    Compare with previous version

    By Raymond Hackley on 2022-03-03T16:14:47

  • Administrator resolved all threads · Imported

    resolved all threads

    By Raymond Hackley on 2022-03-03T16:16:11

  • Administrator approved this merge request · Imported

    approved this merge request

    By Alexey Min on 2022-03-03T16:16:41

  • Administrator added 1 commit · Imported

    added 1 commit

    • 9833cc8a - samsung-{a3,a5,a7,klte,serranove}: move tm2-touchkey rules to pmos-base (MR 2926)

    Compare with previous version

    By Alexey Min on 2022-03-03T16:20:29

  • Administrator merged · Imported

    merged

  • Administrator added category::device device-samsung-a5 + 1 deleted label · Imported

    added category::device device-samsung-a5 + 1 deleted label

  • Administrator mentioned in merge request !3015 (merged) · Imported

    mentioned in merge request !3015 (merged)

    By Raymond Hackley on 2022-03-21T14:45:27

  • Administrator mentioned in merge request !3192 (merged) · Imported

    mentioned in merge request !3192 (merged)

    By Jack K on 2022-06-05T18:32:06

    • Please register or sign in to reply